linux-kernel - Re: [PATCH] audit: remove stray newlines from audit_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140305222703.GW16640@madcap2.tricolour.ca>
Date:	Wed, 5 Mar 2014 17:27:03 -0500
From:	Richard Guy Briggs <rgb@...hat.com>
To:	Josh Boyer <jwboyer@...oraproject.org>
Cc:	Eric Paris <eparis@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] audit: remove stray newlines from audit_log_lost messages

On 14/03/05, Josh Boyer wrote:
> Calling audit_log_lost with a \n in the format string leads to extra
> newlines in dmesg.  That function will eventually call audit_panic which
> uses pr_err with an explicit \n included.  Just make these calls match the
> others that lack \n.
> 
> Reported-by: Jonathan Kamens <jik@...ens.brookline.ma.us>
> Signed-off-by: Josh Boyer <jwboyer@...oraproject.org>

Ack.  queued.

> ---
>  kernel/audit.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/audit.c b/kernel/audit.c
> index 34c5a23..f6bce4d 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -396,7 +396,7 @@ static void audit_printk_skb(struct sk_buff *skb)
>  		if (printk_ratelimit())
>  			pr_notice("type=%d %s\n", nlh->nlmsg_type, data);
>  		else
> -			audit_log_lost("printk limit exceeded\n");
> +			audit_log_lost("printk limit exceeded");
>  	}
>  
>  	audit_hold_skb(skb);
> @@ -412,7 +412,7 @@ static void kauditd_send_skb(struct sk_buff *skb)
>  		BUG_ON(err != -ECONNREFUSED); /* Shouldn't happen */
>  		if (audit_pid) {
>  			pr_err("*NO* daemon at audit_pid=%d\n", audit_pid);
> -			audit_log_lost("auditd disappeared\n");
> +			audit_log_lost("auditd disappeared");
>  			audit_pid = 0;
>  			audit_sock = NULL;
>  		}
> -- 
> 1.8.5.3

- RGB

--
Richard Guy Briggs <rbriggs@...hat.com>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/