lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 5 Mar 2014 16:01:00 -0800 From: Cody P Schafer <cody@...ux.vnet.ibm.com> To: Linux PPC <linuxppc-dev@...ts.ozlabs.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: LKML <linux-kernel@...r.kernel.org>, Paul Mackerras <paulus@...ba.org>, Arnaldo Carvalho de Melo <acme@...stprotocols.net>, Ingo Molnar <mingo@...hat.com>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Michael Ellerman <michael@...erman.id.au>, scottwood@...escale.com, Peter Zijlstra <peterz@...radead.org>, Cody P Schafer <cody@...ux.vnet.ibm.com> Subject: [PATCH v4 01/11] sysfs: create bin_attributes under the requested group bin_attributes created/updated in create_files() (such as those listed via (struct device).attribute_groups) were not placed under the specified group, and instead appeared in the base kobj directory. Fix this by making bin_attributes use creating code similar to normal attributes. A quick grep shows that no one is using bin_attrs in a named attribute group yet, so we can do this without breaking anything in usespace. Note that I do not add is_visible() support to bin_attributes, though that could be done as well. Signed-off-by: Cody P Schafer <cody@...ux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> --- Currently in: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-next with commit-id: aabaf4c2050d21d39fe11eec889c508e84d6a328 --- fs/sysfs/group.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/fs/sysfs/group.c b/fs/sysfs/group.c index 6b57938..aa04068 100644 --- a/fs/sysfs/group.c +++ b/fs/sysfs/group.c @@ -70,8 +70,11 @@ static int create_files(struct kernfs_node *parent, struct kobject *kobj, if (grp->bin_attrs) { for (bin_attr = grp->bin_attrs; *bin_attr; bin_attr++) { if (update) - sysfs_remove_bin_file(kobj, *bin_attr); - error = sysfs_create_bin_file(kobj, *bin_attr); + kernfs_remove_by_name(parent, + (*bin_attr)->attr.name); + error = sysfs_add_file_mode_ns(parent, + &(*bin_attr)->attr, true, + (*bin_attr)->attr.mode, NULL); if (error) break; } -- 1.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists