linux-kernel - Re: [PATCH 1/6][RFC] syscall: define syscall_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <531833F0.8080300@imgtec.com>
Date:	Thu, 6 Mar 2014 08:38:08 +0000
From:	Markos Chandras <Markos.Chandras@...tec.com>
To:	Richard Guy Briggs <rgb@...hat.com>, <linux-audit@...hat.com>,
	<linux-kernel@...r.kernel.org>
CC:	<eparis@...hat.com>, <sgrubb@...hat.com>, <oleg@...hat.com>,
	<linux-mips@...ux-mips.org>,
	<user-mode-linux-devel@...ts.sourceforge.net>,
	<linux-arch@...r.kernel.org>
Subject: Re: [PATCH 1/6][RFC] syscall: define syscall_get_arch() for each
 audit-supported arch

Hi Richard,

On 03/05/2014 09:27 PM, Richard Guy Briggs wrote:
> Each arch that supports audit requires syscall_get_arch() to able to log and
> identify architecture-dependent syscall numbers.  The information is used in at
> least two different subsystems, so standardize it in the same call across all
> arches.
>
> Signed-off-by: Richard Guy Briggs <rgb@...hat.com>
>
> ---
> diff --git a/arch/mips/include/asm/syscall.h b/arch/mips/include/asm/syscall.h
> index 81c8913..41ecde4 100644
> --- a/arch/mips/include/asm/syscall.h
> +++ b/arch/mips/include/asm/syscall.h
> @@ -103,7 +103,7 @@ extern const unsigned long sysn32_call_table[];
>
>   static inline int __syscall_get_arch(void)
>   {
> -	int arch = EM_MIPS;
> +	int arch = AUDIT_ARCH_MIPS;
>   #ifdef CONFIG_64BIT
>   	arch |=  __AUDIT_ARCH_64BIT;
>   #endif
> @@ -113,4 +113,10 @@ static inline int __syscall_get_arch(void)
>   	return arch;
>   }
>
> +static inline int syscall_get_arch(struct task_struct *task,
> +				   struct pt_regs *regs)
> +{
> +	return __syscall_get_arch();
> +}
> +
>   #endif	/* __ASM_MIPS_SYSCALL_H */

This is already fixed for MIPS

http://patchwork.linux-mips.org/patch/6398/

The code is in linux-next targeting 3.15 as far as I can tell.

-- 
markos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/