lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 6 Mar 2014 09:53:58 +0100 From: Arend van Spriel <arend@...adcom.com> To: Stephen Rothwell <sfr@...b.auug.org.au>, "John W. Linville" <linville@...driver.com> CC: <linux-next@...r.kernel.org>, <linux-kernel@...r.kernel.org>, "Hante Meuleman" <meuleman@...adcom.com> Subject: Re: linux-next: build failure after merge of the wireless-next tree On 03/06/2014 03:43 AM, Stephen Rothwell wrote: > Hi John, > > After merging the wireless-next tree, today's linux-next build > (arm multi_v7_defconfig) failed like this: > > drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c: In function > 'brcmf_sdio_intr_rstatus': > drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c:2464:3: error: > implicit declaration of function 'atomic_set_mask' > [-Werror=implicit-function-declaration] > > Caused by commit c98db0bec72a ("brcmfmac: Use atomic functions for > intstatus update"). Arm does not seem to provide > atomic_set_mask()? > > I reverted that commit for today. That is fine. The kbuild robot also found issue with this function on other archs. I must say I am surprised as this code fragment in asm-generic/atomic.h suggests it is needed for SMP to work (?): 20 #ifdef CONFIG_SMP 21 /* Force people to define core atomics */ 22 # if !defined(atomic_add_return) || !defined(atomic_sub_return) || \ 23 !defined(atomic_clear_mask) || !defined(atomic_set_mask) 24 # error "SMP requires a little arch-specific magic" 25 # endif 26 #endif Maybe this requirement is no longer valid. Anyway. I will sent revert patch and replacement to John. Thanks, Arend -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists