lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 6 Mar 2014 18:33:50 +0800 From: Wang YanQing <udknight@...il.com> To: Tomi Valkeinen <tomi.valkeinen@...com> Cc: plagnioj@...osoft.com, fengguang.wu@...el.com, linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] video: fbdev: uvesafb: use CONFIG_X86_PAE surround _PAGE_NX check code On Thu, Mar 06, 2014 at 11:56:37AM +0200, Tomi Valkeinen wrote: > I don't like this, I think this makes the code more messy, just to avoid > that warning. > > And it might even be buggy. For your patch to work correctly, you need > to know the internals of _PAGE_NX, i.e. that when CONFIG_X86_PAE is not > defined, _PAGE_NX is 0. But the driver should not depend on things like > that. If _PAGE_NX is changed later, the driver will not work correctly. > Very right! Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists