linux-kernel - Re: Patch[Kernel 3.13.5]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 6 Mar 2014 11:58:21 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Nick Krause <nickkrause@...patico.ca>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"alan@...rguk.ukuu.org.uk" <alan@...rguk.ukuu.org.uk>,
	David Daney <ddaney@...iumnetworks.com>,
	Ralf Baechle <ralf@...ux-mips.org>, linux-mips@...ux-mips.org
Subject: Re: Patch[Kernel 3.13.5]

On Thu, Mar 06, 2014 at 04:00:04AM +0000, Nick Krause wrote:
> Here is my first patch, adding a break point to fix bug 60845, case fallout through on switch 
> in arch/mips/pci/msi-octeon.c.
> 
> --- //home/nick/linux-3.13.5/arch/mips/pci/msi-octeon.c.orig    2014-03-05 22:48:19.084372515 -0500
> +++ //home/nick/linux-3.13.5/arch/mips/pci/msi-octeon.c    2014-03-05 22:48:48.388372344 -0500
> @@ -150,6 +150,7 @@ msi_irq_allocated:
>          msg.address_lo =
>              ((128ul << 20) + CVMX_PCI_MSI_RCV) & 0xffffffff;
>          msg.address_hi = ((128ul << 20) + CVMX_PCI_MSI_RCV)>> 32;
> +        break;
>      case OCTEON_DMA_BAR_TYPE_BIG:
>          /* When using big bar, Bar 0 is based at 0 */
>          msg.address_lo = (0 + CVMX_PCI_MSI_RCV) & 0xffffffff;
> Got one error no maintainer otherwise not issues with coding style.

Looks like a real bug you've found, as e8635b484f644 still has the
"break" in there.

However, if you want to learn how to prepare patches properly, take a
look at Documentation/SubmittingPatches.

There it also says how to find out who exactly to send this patch to:

$ ./scripts/get_maintainer.pl -f arch/mips/pci/msi-octeon.c
Ralf Baechle <ralf@...ux-mips.org> (supporter:MIPS)
linux-mips@...ux-mips.org (open list:MIPS)

I've CCed them.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/