linux-kernel - Re: [PATCH v3 Resend 2/3] regulator: Add support for S2MPA01 regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 6 Mar 2014 16:52:21 +0530
From:	Sachin Kamat <sachin.kamat@...aro.org>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH v3 Resend 2/3] regulator: Add support for S2MPA01 regulator

Hi Krzysztof,

On 6 March 2014 16:10, Krzysztof Kozlowski <k.kozlowski@...sung.com> wrote:
> On Thu, 2014-03-06 at 15:30 +0530, Sachin Kamat wrote:
>> Add support for S2MPA01 voltage and current regulator.

>> +
>> +struct s2mpa01_info {
>> +     struct regulator_dev *rdev[S2MPA01_REGULATOR_MAX];
>
> Hi,
>
> It seems that s2mpa01_info->rdev is not used anywhere, except as return
> value of devm_regulator_register. I think you can remove it completely.

Yes. I will send a follow up patch for this.

>
> Beside that, can this driver be merged into existing s2mps11 regulator
> driver?

Haven't analyzed this yet. Will look into the possibility of consolidation
later.

Thank you for your feedback.

-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/