| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <5318779C.8030901@free-electrons.com>
Date: Thu, 06 Mar 2014 14:26:52 +0100
From: Gregory CLEMENT <gregory.clement@...e-electrons.com>
To: Andrew Lunn <andrew@...n.ch>
CC: Jason Cooper <jason@...edaemon.net>,
Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>,
linux-arm-kernel@...ts.infradead.org,
Lior Amsalem <alior@...vell.com>,
Tawfik Bayouk <tawfik@...vell.com>,
Nadav Haklai <nadavh@...vell.com>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: mvebu: add Device Tree for the Armada 385 RD board
Hi Andrew,
On 06/03/2014 14:14, Andrew Lunn wrote:
> On Thu, Mar 06, 2014 at 01:11:08PM +0100, Gregory CLEMENT wrote:
>> The Armada 385 RD board is the reference design board from Marvell
>> for the Armada 385 SoC. This commit adds a Device Tree description for
>> this board, which enables the following features:
>>
>> * Network interfaces
>> * I2C bus
>> * Serial port
>> * SPI bus, with a SPI flash
>> * PCIe interface
>>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@...e-electrons.com>
>> ---
>> Hi,
>>
>> I have received this board only recently, so that why its device tree
>> comes only now. This patch should not cause any trouble to other part
>> of the kernel, so that's why I think it is reasonable to have it in
>> 3.15.
>>
>> Thanks,
>>
>> Gregory
>>
>>
>> arch/arm/boot/dts/Makefile | 3 +-
>> arch/arm/boot/dts/armada-385-rd.dts | 104 ++++++++++++++++++++++++++++++++++++
>> 2 files changed, 106 insertions(+), 1 deletion(-)
>> create mode 100644 arch/arm/boot/dts/armada-385-rd.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index f7d678808122..9155cf48e1b1 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -153,7 +153,8 @@ dtb-$(CONFIG_MACH_ARMADA_370) += \
>> dtb-$(CONFIG_MACH_ARMADA_375) += \
>> armada-375-db.dtb
>> dtb-$(CONFIG_MACH_ARMADA_38X) += \
>> - armada-385-db.dtb
>> + armada-385-db.dtb \
>> + armada-385-rd.dtb
>> dtb-$(CONFIG_MACH_ARMADA_XP) += \
>> armada-xp-axpwifiap.dtb \
>> armada-xp-db.dtb \
>> diff --git a/arch/arm/boot/dts/armada-385-rd.dts b/arch/arm/boot/dts/armada-385-rd.dts
>> new file mode 100644
>> index 000000000000..951bd91059e1
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/armada-385-rd.dts
>> @@ -0,0 +1,104 @@
>> +/*
>> + * Device Tree file for Marvell Armada 385 Reference Design board
>> + * (RD-88F6820-AP)
>> + *
>> + * Copyright (C) 2014 Marvell
>> + *
>> + * Gregory CLEMENT <gregory.clement@...e-electrons.com>
>> + * Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
>> + *
>> + * This file is licensed under the terms of the GNU General Public
>> + * License version 2. This program is licensed "as is" without any
>> + * warranty of any kind, whether express or implied.
>> + */
>> +
>> +/dts-v1/;
>> +#include "armada-385.dtsi"
>> +
>> +/ {
>> + model = "Marvell Armada 385 Reference Design";
>> + compatible = "marvell,a385-rd", "marvell,armada385", "marvell,armada38x";
>> +
>> + chosen {
>> + bootargs = "console=ttyS0,115200 earlyprintk";
>> + };
>> +
>> + memory {
>> + device_type = "memory";
>> + reg = <0x00000000 0x10000000>; /* 256 MB */
>> + };
>> +
>> + soc {
>> + ranges = <MBUS_ID(0xf0, 0x01) 0 0xf1000000 0x100000
>> + MBUS_ID(0x01, 0x1d) 0 0xfff00000 0x100000>;
>> +
>> + internal-regs {
>> + spi@...00 {
>> + status = "okay";
>> +
>> + spi-flash@0 {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + compatible = "m25p128";
>
> Hi Gregory
>
> I guess checkpatch.pl is probably complaining about missing vendor
> prefix?
>
yes and also about m25p128 itself because it was not explicitly written
in Documentation/devicetree/bindings/. Actually it was written to "see the
"m25p_ids" table in drivers/mtd/devices/m25p80.c for the list of" the compatible
name.
For the first warning I can add the vendor part, but for the other warning, do we
really want to copy the m25p_ids table in Documentation/devicetree/bindings/mtd/m25p80.txt ?
>> + reg = <0>; /* Chip select 0 */
>> + spi-max-frequency = <108000000>;
>> + };
>> + };
>> +
>> + i2c@...00 {
>> + status = "okay";
>> + clock-frequency = <100000>;
>> + };
>> +
>> + serial@...00 {
>> + clock-frequency = <200000000>;
>> + status = "okay";
>> + };
>> +
>> +
>> + /*
>> + * The Ethernet nodes are not ordered by
>> + * address on purpose. Indeed the first
>> + * Ethernet port of the board (Giga0) is
>> + * located at 0x70000 whereas the the second
>> + * Ethernet(Giga 1) port is located at
>> + * 0x30000.
>> + */
>> +
>> + ethernet@...00 {
>> + status = "okay";
>> + phy = <&phy0>;
>> + phy-mode = "rgmii";
>> + };
>> +
>> + ethernet@...00 {
>> + status = "okay";
>> + phy = <&phy1>;
>> + phy-mode = "rgmii";
>> + };
>> +
>
> I think you can use aliases to get the order correct, independent of
> how you list them in DT. That should be a lot safer than assuming
> things are instantiated from top to bottom.
It sounds interesting, how would you do this?
Thanks,
Gregory
>
> Andrew
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists