lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 6 Mar 2014 09:30:42 -0600 From: Serge Hallyn <serge.hallyn@...ntu.com> To: Jeff Layton <jlayton@...hat.com> Cc: James Morris <james.l.morris@...cle.com>, Serge Hallyn <serge.hallyn@...onical.com>, linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org, linux-nfs@...r.kernel.org Subject: Re: [PATCH] security: have cap_dentry_init_security return error Quoting Jeff Layton (jlayton@...hat.com): > Currently, cap_dentry_init_security returns 0 without actually > initializing the security label. This confuses its only caller > (nfs4_label_init_security) which expects an error in that situation, and > causes it to end up sending out junk onto the wire instead of simply > suppressing the label in the attributes sent. > > When CONFIG_SECURITY is disabled, security_dentry_init_security returns > -EOPNOTSUPP. Have cap_dentry_init_security do the same. > > Signed-off-by: Jeff Layton <jlayton@...hat.com> Acked-by: Serge E. Hallyn <serge.hallyn@...ntu.com> > --- > security/capability.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/capability.c b/security/capability.c > index 8b4f24ae4338..9323bbeba296 100644 > --- a/security/capability.c > +++ b/security/capability.c > @@ -116,7 +116,7 @@ static int cap_dentry_init_security(struct dentry *dentry, int mode, > struct qstr *name, void **ctx, > u32 *ctxlen) > { > - return 0; > + return -EOPNOTSUPP; > } > > static int cap_inode_alloc_security(struct inode *inode) > -- > 1.8.5.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists