lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 6 Mar 2014 08:29:51 -0800
From:	Dmitry Torokhov <>
To:	Robert Baldyga <>
Subject: Re: [PATCH v2] mfd: max8997: use regmap to access registers

On Thu, Mar 06, 2014 at 07:42:30AM +0100, Robert Baldyga wrote:
> Hi,
> On 03/05/2014 07:54 PM, Dmitry Torokhov wrote:
> > Hi Robert,
> > 
> > On Wed, Mar 05, 2014 at 03:58:17PM +0100, Robert Baldyga wrote:
> >>  
> >> -int max8997_write_reg(struct i2c_client *i2c, u8 reg, u8 value)
> >> +int max8997_write_reg(struct regmap *map, u8 reg, u8 value)
> > 
> > Why don't you make read/write reg to take struct max8997_dev as argument
> > instead of regmap? regmap seems to be the current implementation du jur,
> > but that is core's detail, functions do not need to care.
> > 
> > Thanks.
> > 
> It's because there are few regmaps in max8997_dev, and read/write reg
> functions has no way to check which regmap should be used. I think it
> would be clearer if I remove this functions and use regmap_read and
> regmap_write instead, because there is no particular purpose for them.

I see.. Then another question - why do the regmaps belong to the core
of the driver instead of individual functions? Why haptic regmap, for
example, can not be initialized in haptic code instead?


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists