lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140306162951.GA14318@core.coreip.homeip.net> Date: Thu, 6 Mar 2014 08:29:51 -0800 From: Dmitry Torokhov <dmitry.torokhov@...il.com> To: Robert Baldyga <r.baldyga@...sung.com> Cc: sameo@...ux.intel.com, lee.jones@...aro.org, myungjoo.ham@...sung.com, cw00.choi@...sung.com, cooloney@...il.com, rpurdie@...ys.net, dbaryshkov@...il.com, dwmw2@...radead.org, lgirdwood@...il.com, broonie@...nel.org, a.zummo@...ertech.it, paul.gortmaker@...driver.com, linux-kernel@...r.kernel.org, linux-input@...r.kernel.org, linux-leds@...r.kernel.org, rtc-linux@...glegroups.com, m.szyprowski@...sung.com, k.kozlowski@...sung.com Subject: Re: [PATCH v2] mfd: max8997: use regmap to access registers On Thu, Mar 06, 2014 at 07:42:30AM +0100, Robert Baldyga wrote: > Hi, > > On 03/05/2014 07:54 PM, Dmitry Torokhov wrote: > > Hi Robert, > > > > On Wed, Mar 05, 2014 at 03:58:17PM +0100, Robert Baldyga wrote: > >> > >> -int max8997_write_reg(struct i2c_client *i2c, u8 reg, u8 value) > >> +int max8997_write_reg(struct regmap *map, u8 reg, u8 value) > > > > Why don't you make read/write reg to take struct max8997_dev as argument > > instead of regmap? regmap seems to be the current implementation du jur, > > but that is core's detail, functions do not need to care. > > > > Thanks. > > > > It's because there are few regmaps in max8997_dev, and read/write reg > functions has no way to check which regmap should be used. I think it > would be clearer if I remove this functions and use regmap_read and > regmap_write instead, because there is no particular purpose for them. I see.. Then another question - why do the regmaps belong to the core of the driver instead of individual functions? Why haptic regmap, for example, can not be initialized in haptic code instead? Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists