linux-kernel - Re: [PATCH] tile: avoid overflow in ns2cycles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5318A7FF.8010502@tilera.com>
Date:	Thu, 6 Mar 2014 11:53:19 -0500
From:	Chris Metcalf <cmetcalf@...era.com>
To:	Henrik Austad <henrik@...tad.us>
CC:	LKML <linux-kernel@...r.kernel.org>,
	John Stultz <johnstul@...ibm.com>,
	Mike Galbraith <bitbucket@...ine.de>,
	Salman Qazi <sqazi@...gle.com>
Subject: Re: [PATCH] tile: avoid overflow in ns2cycles

On 3/4/2014 3:20 AM, Henrik Austad wrote:
> In commit 4cecf6d401a ("sched, x86: Avoid unnecessary overflow in
> sched_clock") and in recent patch "clocksource: avoid unnecessary
> overflow in cyclecounter_cyc2ns()" https://lkml.org/lkml/2014/3/4/17,
> the mult-shift approach is replaced by 2 steps to avoid storing a large,
> intermediate value that could overflow.
>
> arch/tile/kernel/time.c has a similar pattern in cycles2ns, and this
> copies the same pattern in this function
>
> CC: John Stultz <johnstul@...ibm.com>
> CC: Mike Galbraith <bitbucket@...ine.de>
> CC: Salman Qazi <sqazi@...gle.com>
> Signed-off-by: Henrik Austad <henrik@...tad.us>
> ---
>  arch/tile/kernel/time.c |   10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)

Thanks; taken into the tile tree (with some minor whitespace formatting tweaks).

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/