linux-kernel - thermal-zones DT node bound by name rather than compatible property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <5318B6ED.3060104@wwwdotorg.org>
Date:	Thu, 06 Mar 2014 10:57:01 -0700
From:	Stephen Warren <swarren@...dotorg.org>
To:	Eduardo Valentin <eduardo.valentin@...com>
CC:	Wei Ni <wni@...dia.com>, Zhang Rui <rui.zhang@...el.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>
Subject: thermal-zones DT node bound by name rather than compatible property

Commit 4e5e4705bf69 "thermal: introduce device tree parser" introduced
the text below into Documentation/devicetree/bindings/thermal/thermal.txt:

> * The thermal-zones node
> 
> The "thermal-zones" node is a container for all thermal zone nodes. It shall
> contain only sub-nodes describing thermal zones as in the section
> "Thermal zone nodes". The "thermal-zones" node appears under "/".

This implies that software must find the thermal-zones node by node
name. Node names aren't supposed to be significant in DT. Rather,
software is supposed to bind to a node by searching for all nodes with a
particular value in the compatible property. While there are some legacy
counter-examples such as /aliases, /chosen, and /cpus, I don't think we
should propagate any more of these in new bindings.

Can this mistake in the binding definition be rectified, or is it too late?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/