linux-kernel - Re: [PATCH v7 1/2] ARM: avoid tracers in soft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <531908b6.44f8440a.03ab.0cce@mx.google.com>
Date:	Thu, 06 Mar 2014 15:45:53 -0800
From:	Sebastian Capella <sebastian.capella@...aro.org>
To:	Sebastian Capella <sebastian.capella@...aro.org>,
	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	linaro-kernel@...ts.linaro.org,
	linux-arm-kernel@...ts.infradead.org,
	"Thomas Gleixner" <tglx@...utronix.de>
Cc:	"Russell King" <linux@....linux.org.uk>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"Will Deacon" <will.deacon@....com>,
	"Robin Holt" <robin.m.holt@...il.com>,
	"Lorenzo Pieralisi" <lorenzo.pieralisi@....com>,
	"Konstantin Khlebnikov" <k.khlebnikov@...sung.com>,
	"Steven Capper" <steve.capper@...aro.org>,
	"Stephen Warren" <swarren@...dia.com>, "Tejun Heo" <tj@...nel.org>
Subject: Re: [PATCH v7 1/2] ARM: avoid tracers in soft_restart

Quoting Sebastian Capella (2014-03-05 02:50:04)
> Use of tracers in local_irq_disable is causes recursive aborts when
> called with irqs disabled and using a temporary stack (hibernation).
> Replace local_irq_disable with raw_local_irq_disable instead to
> avoid tracers.
> 
> Signed-off-by: Sebastian Capella <sebastian.capella@...aro.org>
> Cc: Russell King <linux@....linux.org.uk>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Will Deacon <will.deacon@....com>
> Cc: Robin Holt <robin.m.holt@...il.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@....com>
> Cc: Konstantin Khlebnikov <k.khlebnikov@...sung.com>
> Cc: Steven Capper <steve.capper@...aro.org>
> Cc: Stephen Warren <swarren@...dia.com>
> Cc: Tejun Heo <tj@...nel.org>
> ---
>  arch/arm/kernel/process.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index 92f7b15..f58b723 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -100,7 +100,7 @@ void soft_restart(unsigned long addr)
>         u64 *stack = soft_restart_stack + ARRAY_SIZE(soft_restart_stack);
>  
>         /* Disable interrupts first */
> -       local_irq_disable();
> +       raw_local_irq_disable();
>         local_fiq_disable();
>  
>         /* Disable the L2 if we're the last man standing. */
> -- 
> 1.7.9.5
Hi,

I have not heard any feedback on this change, since V3 of the
patchset.

Is everyone ok with this as it is?

Thomas, thanks for proposing this, is this looking ok to you?

Thanks!

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/