lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 5 Mar 2014 21:55:11 -0500 From: Richard Guy Briggs <rgb@...hat.com> To: AKASHI Takahiro <takahiro.akashi@...aro.org> Cc: Will Deacon <will.deacon@....com>, viro@...iv.linux.org.uk, eparis@...hat.com, Catalin.Marinas@....com, dsaxena@...aro.org, arndb@...db.de, linux-arm-kernel@...ts.infradead.org, linaro-kernel@...ts.linaro.org, linux-kernel@...r.kernel.org, linux-audit@...hat.com Subject: Re: [PATCH v6 2/2] arm64: audit: Add audit hook in ptrace/syscall_trace On 14/03/06, AKASHI Takahiro wrote: > On 03/01/2014 01:15 AM, Will Deacon wrote: > >On Fri, Feb 28, 2014 at 05:17:15AM +0000, AKASHI Takahiro wrote: > >>This patch adds auditing functions on entry to or exit from > >>every system call invocation. > >> > >>Acked-by: Richard Guy Briggs <rgb@...hat.com> > >>Signed-off-by: AKASHI Takahiro <takahiro.akashi@...aro.org> > >>--- > >> arch/arm64/kernel/ptrace.c | 54 ++++++++++++++++++++++++++------------------ > >> 1 file changed, 32 insertions(+), 22 deletions(-) > > > >I think you need to do something like I did for arch/arm/, where we have > >separate trace functions for entry/exit to make sure that we invoke the > >various helpers in the correct order (for example, you want to invoke all > >the debug stuff *first* on entry, but *last* on exit). > > > >Will > > If you mean syscall_trace_enter()/exit(), I will follow your suggestion > for readability. It isn't so much a question of readability, but rather correctness, undoing operations in the opposite order on exit that they were done on entry. > -Takahiro AKASHI - RGB -- Richard Guy Briggs <rbriggs@...hat.com> Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat Remote, Ottawa, Canada Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists