| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 7 Mar 2014 11:04:11 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: "Wang, Xiaoming" <xiaoming.wang@...el.com> Cc: gregkh@...uxfoundation.org, valentina.manea.m@...il.com, standby24x7@...il.com, devel@...verdev.osuosl.org, chuansheng.liu@...el.com, dongxing.zhang@...el.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH] [staging][r8188eu]: memory leak in rtw_free_cmd_obj if command is (_Set_Drv_Extra) On Fri, Mar 07, 2014 at 03:01:34PM -0500, Wang, Xiaoming wrote: > pcmd->parmbuf->pbuf has been allocated if command is GEN_CMD_CODE(_Set_Drv_Extra), > and it enqueued by rtw_enqueue_cmd. rtw_cmd_thread dequeue pcmd by rtw_dequeue_cmd. > The memory leak happened on this branch "if( _FAIL == rtw_cmd_filter(pcmdpriv, pcmd) )" > which goto post_process directly against freeing pcmd->parmbuf->pbuf in > rtw_drvextra_cmd_hdl which is the cmd_hdl if command is (_Set_Drv_Extra). > This patch free pcmd->parmbuf->pbuf on forgotten branch to avoid memory leak. > > Signed-off-by: Zhang Dongxing <dongxing.zhang@...el.com> > Signed-off-by: xiaoming wang <xiaoming.wang@...el.com> This code looks completely different in linux-next. Please redo on top of linux-next if it's still needed. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists