linux-kernel - Re: [PATCH] staging: frontier: fix memory leak in usb_alphatrack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140307081441.GD4774@mwanda>
Date:	Fri, 7 Mar 2014 11:14:41 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Daeseok Youn <daeseok.youn@...il.com>
Cc:	gregkh@...uxfoundation.org, d@...libre.com,
	paul.gortmaker@...driver.com, sara.bird.iar@...il.com,
	standby24x7@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: frontier: fix memory leak in
 usb_alphatrack_probe()

On Fri, Mar 07, 2014 at 05:02:25PM +0900, Daeseok Youn wrote:
> 
> oldi_buffer and write_buffer need to free when usb_alphatrack_delete()
> is called.
> 
> Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>
> ---
>  drivers/staging/frontier/alphatrack.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/frontier/alphatrack.c b/drivers/staging/frontier/alphatrack.c
> index edd5cef..4d630da 100644
> --- a/drivers/staging/frontier/alphatrack.c
> +++ b/drivers/staging/frontier/alphatrack.c
> @@ -208,6 +208,8 @@ static void usb_alphatrack_delete(struct usb_alphatrack *dev)
>  	kfree(dev->ring_buffer);
>  	kfree(dev->interrupt_in_buffer);
>  	kfree(dev->interrupt_out_buffer);
> +	kfree(dev->oldi_buffer);
> +	kfree(dev->write_buffer);
>  	kfree(dev);		/* fixme oldi_buffer */
                                   ^^^^^^^^^^^^^^^^^
Remove this comment now?

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/