[<prev] [next>] [day] [month] [year] [list]
Message-ID: <1569666.TNMhHTO1Tb@daeseok-laptop.cloud.net>
Date:	Fri, 07 Mar 2014 17:25:55 +0900
From:	Daeseok Youn <daeseok.youn@...il.com>
To:	gregkh@...uxfoundation.org
Cc:	d@...libre.com, paul.gortmaker@...driver.com,
	sara.bird.iar@...il.com, dan.carpenter@...cle.com,
	standby24x7@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH v2] staging: frontier: fix memory leak in usb_alphatrack_probe()
oldi_buffer and write_buffer need to free when usb_alphatrack_delete()
is called.
Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>
---
v2: remove the unneeded comment.
 drivers/staging/frontier/alphatrack.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/frontier/alphatrack.c b/drivers/staging/frontier/alphatrack.c
index edd5cef..e59ee51 100644
--- a/drivers/staging/frontier/alphatrack.c
+++ b/drivers/staging/frontier/alphatrack.c
@@ -208,7 +208,9 @@ static void usb_alphatrack_delete(struct usb_alphatrack *dev)
 	kfree(dev->ring_buffer);
 	kfree(dev->interrupt_in_buffer);
 	kfree(dev->interrupt_out_buffer);
-	kfree(dev);		/* fixme oldi_buffer */
+	kfree(dev->oldi_buffer);
+	kfree(dev->write_buffer);
+	kfree(dev);
 }
 
 /** usb_alphatrack_interrupt_in_callback */
-- 
1.7.4.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Powered by blists - more mailing lists
 
