linux-kernel - Re: [PATCH 8/8] tools, perf: Make get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140307131957.GD13974@krava.brq.redhat.com>
Date:	Fri, 7 Mar 2014 14:19:57 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	acme@...hat.com, mingo@...nel.org, linux-kernel@...r.kernel.org,
	eranian@...gle.com, namhyung@...nel.org,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 8/8] tools, perf: Make get_srcline fall back to sym+offset

On Thu, Feb 27, 2014 at 08:22:32PM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@...ux.intel.com>
> 
> When the source line is not found fall back to sym + offset.
> This is generally much more useful than a raw address.
> For this we need to pass in the symbol from the caller.
> For some callers it's awkward to compute, so we stay
> at the old behaviour.

could we fallback for 0 src lines as well? I'm getting following:

            |          |--99.85%-- _IO_file_xsputn@@GLIBC_2.2.5 .:0
            |          |          __GI___mempcpy .:0
            |          |          __GI___mempcpy .:0
            |          |          __GI___mempcpy .:0
            |          |          __GI___mempcpy .:0
            |          |          __GI___mempcpy .:0
            |          |          __GI___mempcpy .:0
            |          |          __GI___mempcpy .:0
            |          |          __GI___mempcpy .:0
            |          |          __GI___mempcpy .:0

also it would be handy to show raw address (object based).. maybe for -v option?

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/