linux-kernel - Re: [PATCH v3 3/4] checkpatch: check compatible strings in .c and .h too

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5319C9CA.1080604@epfl.ch>
Date:	Fri, 07 Mar 2014 14:29:46 +0100
From:	Florian Vaussard <florian.vaussard@...l.ch>
To:	Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>
CC:	Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/4] checkpatch: check compatible strings in .c and
 .h too



On 03/07/2014 02:26 PM, Florian Vaussard wrote:
> From: Joe Perches <joe@...ches.com>
> 
> From: Joe Perches <joe@...ches.com>
> 

Mmmh, sorry for this. I will resend.

> Look for ".compatible = "foo" strings not only in .dts files, but
> in .c and .h too.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> [florian.vaussard@...l.ch: split patch, commit log]
> Signed-off-by: Florian Vaussard <florian.vaussard@...l.ch>
> ---
>  scripts/checkpatch.pl | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 96f10ba..9205153 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2041,8 +2041,10 @@ sub process {
>  		}
>  
>  # check for DT compatible documentation
> -		if (defined $root && $realfile =~ /\.dts/ &&
> -		    $rawline =~ /^\+\s*compatible\s*=/) {
> +		if (defined $root &&
> +			(($realfile =~ /\.dtsi?$/ && $line =~ /^\+\s*compatible\s*=\s*\"/) ||
> +			 ($realfile =~ /\.[ch]$/ && $line =~ /^\+.*\.compatible\s*=\s*\"/))) {
> +
>  			my @compats = $rawline =~ /\"([a-zA-Z0-9\-\,\.\+_]+)\"/g;
>  
>  			foreach my $compat (@compats) {
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/