[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140307144500.GI1852@moon>
Date: Fri, 7 Mar 2014 18:45:00 +0400
From: Cyrill Gorcunov <gorcunov@...il.com>
To: Pavel Emelyanov <xemul@...allels.com>
Cc: Artem Fetishev <artem_fetishev@...m.com>,
akpm@...ux-foundation.org, containers@...ts.linux-foundation.org,
linux-kernel@...r.kernel.org, wiebittewas@...glemail.com,
alexandr_terekhov@...m.com
Subject: Re: [PATCH] proc: #68991 Fix GPF in /proc/$PID/map_files
On Fri, Mar 07, 2014 at 06:29:13PM +0400, Pavel Emelyanov wrote:
> On 03/08/2014 06:20 AM, Artem Fetishev wrote:
> > https://bugzilla.kernel.org/show_bug.cgi?id=68991
> >
> > The expected logic of proc_map_files_get_link() is either to return 0 and
> > initialize 'path' or return an error and leave 'path' uninitialized. By the time
> > dname_to_vma_addr() returns 0 the corresponding vma may have already be gone. In
> > this case the path is not initialized but the return value is still 0. This
> > results in 'general protection fault' inside d_path().
> >
> > Steps to reproduce:
> > CONFIG_CHECKPOINT_RESTORE=y
> >
> > fd = open(...);
> > while (1) {
> > mmap(fd, ...);
> > munmap(fd, ...);
> > }
> >
> > ls -la /proc/$PID/map_files
> >
> > Signed-off-by: Artem Fetishev <artem_fetishev@...m.com>
> > Signed-off-by: Aleksandr Terekhov <aleksandr_terekhov@...m.com>
>
> Acked-by: Pavel Emelyanov <xemul@...allels.com>
Good catch, thanks!
Acked-by: Cyrill Gorcunov <gorcunov@...nvz.org>
I suppose this is a stable@ material.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists