linux-kernel - Re: slub: fix leak of 'name' in sysfs_slab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140307153259.GA778@redhat.com>
Date:	Fri, 7 Mar 2014 10:32:59 -0500
From:	Dave Jones <davej@...hat.com>
To:	Vladimir Davydov <vdavydov@...allels.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>, linux-mm@...ck.org,
	cl@...ux-foundation.org, penberg@...nel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: slub: fix leak of 'name' in sysfs_slab_add

On Fri, Mar 07, 2014 at 10:18:04AM +0400, Vladimir Davydov wrote:
 > [adding Andrew to Cc]
 > 
 > On 03/07/2014 01:11 AM, Dave Jones wrote:
 > > The failure paths of sysfs_slab_add don't release the allocation of 'name'
 > > made by create_unique_id() a few lines above the context of the diff below.
 > > Create a common exit path to make it more obvious what needs freeing.
 > > 
 > > Signed-off-by: Dave Jones <davej@...oraproject.org>
 > > 
 > 
 > Since this function was modified in the mmotm tree, I would propose
 > something like this on top of mmotm to avoid further merge conflicts:
 
Looks good to me.

thanks,

	Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/