linux-kernel - Re: [PATCH v6] phy: omap-usb2: move omap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <531A0436.3080201@ti.com>
Date:	Fri, 7 Mar 2014 23:09:02 +0530
From:	Kishon Vijay Abraham I <kishon@...com>
To:	<balbi@...com>
CC:	<linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>
Subject: Re: [PATCH v6] phy: omap-usb2: move omap_usb.h from linux/usb/ to
 linux/phy/

On Friday 07 March 2014 10:20 PM, Felipe Balbi wrote:
> On Fri, Mar 07, 2014 at 10:18:08PM +0530, Kishon Vijay Abraham I wrote:
>> No functional change. Moved omap_usb.h from linux/usb/ to linux/phy/.
>> Also removed the unused members of struct omap_usb (after phy-omap-pipe3
>> started using it's own header file)
>
> does this depend in any other patch ? I get the following when applying
> *only* this patch on top of v3.14-rc5:

yeah.. this is for linux-phy tree. I'll take this patch.

Thanks
Kishon

>
> drivers/phy/phy-omap-usb2.c: In function ‘omap_usb2_suspend’:
> drivers/phy/phy-omap-usb2.c:106:21: error: ‘struct omap_usb’ has no member named ‘is_suspended’
>    if (suspend && !phy->is_suspended) {
>                       ^
> drivers/phy/phy-omap-usb2.c:109:6: error: ‘struct omap_usb’ has no member named ‘is_suspended’
>     phy->is_suspended = 1;
>        ^
> drivers/phy/phy-omap-usb2.c:110:28: error: ‘struct omap_usb’ has no member named ‘is_suspended’
>    } else if (!suspend && phy->is_suspended) {
>                              ^
> drivers/phy/phy-omap-usb2.c:117:6: error: ‘struct omap_usb’ has no member named ‘is_suspended’
>     phy->is_suspended = 0;
>        ^
> drivers/phy/phy-omap-usb2.c: In function ‘omap_usb2_probe’:
> drivers/phy/phy-omap-usb2.c:194:5: error: ‘struct omap_usb’ has no member named ‘is_suspended’
>    phy->is_suspended = 1;
>       ^
> make[1]: *** [drivers/phy/phy-omap-usb2.o] Error 1
> make: *** [drivers/phy/] Error 2
> make: *** Waiting for unfinished jobs....
>    CC [M]  drivers/usb/phy/phy-mxs-usb.o
> drivers/usb/phy/phy-omap-usb3.c:22:32: fatal error: linux/usb/omap_usb.h: No such file or directory
>   #include <linux/usb/omap_usb.h>
>                                  ^
> compilation terminated.
> make[1]: *** [drivers/usb/phy/phy-omap-usb3.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [drivers/usb/phy/] Error 2
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/