linux-kernel - Re: [PATCH] tools/net/Makefile: Define PACKAGE to fix bfd build problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140307.130950.1797371137100057531.davem@davemloft.net>
Date:	Fri, 07 Mar 2014 13:09:50 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	Markos.Chandras@...tec.com
Cc:	linux-kernel@...r.kernel.org, dborkman@...hat.com
Subject: Re: [PATCH] tools/net/Makefile: Define PACKAGE to fix bfd build
 problems

From: Markos Chandras <Markos.Chandras@...tec.com>
Date: Fri, 7 Mar 2014 09:18:28 +0000

> On 03/06/2014 05:54 PM, David Miller wrote:
>> From: Markos Chandras <markos.chandras@...tec.com>
>> Date: Thu, 6 Mar 2014 09:15:54 +0000
>>
>>> Fixes the following build problem with binutils-2.24
>>>
>>> gcc -Wall -O2   -c -o bpf_jit_disasm.o bpf_jit_disasm.c
>>> In file included from bpf_jit_disasm.c:25:0:
>>> /usr/include/bfd.h:35:2: error: #error config.h must be included
>>> before this header
>>>   #error config.h must be included before this header
>>>
>>> This is similar to commit 3ce711a6abc27abce1554e1d671a8762b7187690
>>> "perf tools: bfd.h/libbfd detection fails with recent binutils"
>>>
>>> See: https://sourceware.org/bugzilla/show_bug.cgi?id=14243
>>>
>>> CC: David S. Miller <davem@...emloft.net>
>>> CC: Daniel Borkmann <dborkman@...hat.com>
>>> Signed-off-by: Markos Chandras <markos.chandras@...tec.com>
>>
>> I think your subject needs to be adjusted, this patch doesn't fix a
>> "bfd"
>> build problem.
>>
> Hi David,
> 
> Thanks for the comment. Well it's problem caused by the bfd
> header. However, I suppose you can remove the 'bfd' word from the
> subject as I understand it's confusing. Would you be able to fix this
> before you apply this patch or should I send a new patch?

Please send a new patch, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/