lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 07 Mar 2014 15:41:42 -0500 (EST) From: David Miller <davem@...emloft.net> To: alistair@...ple.id.au Cc: netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org Subject: Re: [PATCH 2/5] IBM Akebono: Add support for a new PHY interface to the IBM emac driver From: Alistair Popple <alistair@...ple.id.au> Date: Thu, 6 Mar 2014 14:52:25 +1100 > + out_be32(dev->reg, in_be32(dev->reg) | WKUP_ETH_RGMIIEN > + | WKUP_ETH_TX_OE | WKUP_ETH_RX_IE); When an expression spans multiple lines, the lines should end with operators rather than begin with them. Also, it would be easier to read this call if parenthesis were put around the third argument and then indented to match, f.e.: out_be32(dev->reg, (in_be32(dev->reg) | WKUP_ETH_RGMIIEN | WKUP_ETH_TX_OE | WKUP_ETH_RX_IE)); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists