linux-kernel - Re: [PATCH RFC v2 04/11] tty: xuartps: Remove bogus comment and register write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140307212816.715e5e19@alan.etchedpixels.co.uk>
Date:	Fri, 7 Mar 2014 21:28:16 +0000
From:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
To:	Soren Brinkmann <soren.brinkmann@...inx.com>
Cc:	Russell King <linux@....linux.org.uk>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>, Arnd Bergmann <arnd@...db.de>,
	Michal Simek <michal.simek@...inx.com>,
	Peter Crosthwaite <peter.crosthwaite@...inx.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-serial@...r.kernel.org
Subject: Re: [PATCH RFC v2 04/11] tty: xuartps: Remove bogus comment and
 register write

On Fri,  7 Mar 2014 11:13:27 -0800
Soren Brinkmann <soren.brinkmann@...inx.com> wrote:

> Signed-off-by: Soren Brinkmann <soren.brinkmann@...inx.com>
> ---
>  drivers/tty/serial/xilinx_uartps.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
> index a4bd6242e72d..a39c2d290902 100644
> --- a/drivers/tty/serial/xilinx_uartps.c
> +++ b/drivers/tty/serial/xilinx_uartps.c
> @@ -1082,11 +1082,7 @@ static void xuartps_console_write(struct console *co, const char *s,
>  
>  	xuartps_writel(ctrl, XUARTPS_CR_OFFSET);
>  
> -	/* restore interrupt state, it seems like there may be a h/w bug
> -	 * in that the interrupt enable register should not need to be
> -	 * written based on the data sheet
> -	 */
> -	xuartps_writel(~imr, XUARTPS_IDR_OFFSET);
> +	/* restore interrupt state */

It would be appropriate for the changelog at least to explain why the
note about the data sheet differing is going away !
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/