linux-kernel - Re: [GIT PULL] x86 fixes for v3.14-rc6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 7 Mar 2014 19:03:09 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	"H. Peter Anvin" <hpa@...ux.intel.com>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Borislav Petkov <bp@...e.de>, Don Zickus <dzickus@...hat.com>,
	Peter Anvin <hpa@...or.com>, Jiri Olsa <jolsa@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Matt Fleming <matt.fleming@...el.com>,
	Ingo Molnar <mingo@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Russ Anderson <rja@....com>,
	Steven Rostedt <rostedt@...dmis.org>, seiji.aguchi@....com,
	Thomas Gleixner <tglx@...utronix.de>,
	Vince Weaver <vincent.weaver@...ne.edu>
Subject: Re: [GIT PULL] x86 fixes for v3.14-rc6

Oww, oww, oww.

DAMMIT.

On Fri, Mar 7, 2014 at 3:25 PM, H. Peter Anvin <hpa@...ux.intel.com> wrote:
>
> A small collection of minor fixes.  The FPU stuff is still pending, I
> fear.  I haven't heard anything from Suresh so I suspect I'm going to
> have to dig into the init specifics myself and fix up the patchset.

I pulled this and then pushed out without test-compiling, because I'm
not used to the x86 trees causing problems. Usually they've gone
through a lot of build tests etc.

But dammit, it's broken:

  arch/x86/kernel/head_64.o: In function `early_idt_handler':
  (.init.text+0x124): undefined reference to `X86_TRAP_NMI'

because X86_TRAP_NMI is an enum, not a #define.

This can not have worked in your tree either, because that thing has
never been anything *but* an enum. So I'm pissed off. This patch was
clearly never tested anywhere. Why was it sent to me?

Grr. Consider yourself cursed at. Saatana.

              Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/