linux-kernel - Re: [PATCH 2/2] mm: Changed pr_warning() to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 07 Mar 2014 20:00:14 -0800
From:	Joe Perches <joe@...ches.com>
To:	Choi Gi-yong <yong@...y.org>
Cc:	tj@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mm: Changed pr_warning() to pr_warn()

On Sat, 2014-03-08 at 12:51 +0900, Choi Gi-yong wrote:

> diff --git a/mm/percpu.c b/mm/percpu.c
[]
> @@ -813,7 +813,7 @@ fail_unlock:
>  fail_unlock_mutex:
>  	mutex_unlock(&pcpu_alloc_mutex);
>  	if (warn_limit) {
> -		pr_warning("PERCPU: allocation failed, size=%zu align=%zu, "
> +		pr_warn("PERCPU: allocation failed, size=%zu align=%zu, "
>  			   "%s\n", size, align, err);

If you're going do to this, please coalesce
the format fragments.

		pr_warn("PERCPU: allocation failed, size=%zu align=%zu, %s\n",
			size, align, err);

> @@ -1690,7 +1690,7 @@ int __init pcpu_embed_first_chunk(size_t reserved_size, size_t dyn_size,
>  
>  	/* warn if maximum distance is further than 75% of vmalloc space */
>  	if (max_distance > VMALLOC_TOTAL * 3 / 4) {
> -		pr_warning("PERCPU: max_distance=0x%zx too large for vmalloc "
> +		pr_warn("PERCPU: max_distance=0x%zx too large for vmalloc "
>  			   "space 0x%lx\n", max_distance,
>  			   VMALLOC_TOTAL);

here too

		pr_warn("PERCPU: max_distance=0x%zx too large for vmalloc space 0x%lx\n",
			max_distance, VMALLOC_TOTAL);

> @@ -1774,7 +1774,7 @@ int __init pcpu_page_first_chunk(size_t reserved_size,
>  
>  			ptr = alloc_fn(cpu, PAGE_SIZE, PAGE_SIZE);
>  			if (!ptr) {
> -				pr_warning("PERCPU: failed to allocate %s page "
> +				pr_warn("PERCPU: failed to allocate %s page "
>  					   "for cpu%u\n", psize_str, cpu);

etc.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/