lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 8 Mar 2014 15:53:10 +0100 From: Stanislaw Gruszka <sgruszka@...hat.com> To: Behan Webster <behanw@...verseincode.com> Cc: Joe Perches <joe@...ches.com>, linville@...driver.com, johannes@...solutions.net, davem@...emloft.net, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, dwmw2@...radead.org, pageexec@...email.hu, Jan-Simon Möller <dl9pf@....de>, Vinícius Tinti <viniciustinti@...il.com>, Mark Charlebois <charlebm@...il.com> Subject: Re: [PATCH v2] mac80211: LLVMLinux: Remove VLAIS usage from mac80211 On Fri, Mar 07, 2014 at 06:15:43PM -0800, Behan Webster wrote: > On 03/07/14 17:56, Joe Perches wrote: > >On Fri, 2014-03-07 at 17:26 -0800, behanw@...verseincode.com wrote: > >>From: Jan-Simon Möller <dl9pf@....de> > >> > >>Replaced the use of a Variable Length Array In Struct (VLAIS) with a C99 > >>compliant equivalent. This is the original VLAIS struct. > >[] > >>diff --git a/net/mac80211/aes_ccm.c b/net/mac80211/aes_ccm.c > >[] > >>@@ -23,12 +23,14 @@ void ieee80211_aes_ccm_encrypt(struct crypto_aead *tfm, u8 *b_0, u8 *aad, > >> u8 *data, size_t data_len, u8 *mic) > >> { > >> struct scatterlist assoc, pt, ct[2]; > >>- struct { > >>- struct aead_request req; > >>- u8 priv[crypto_aead_reqsize(tfm)]; > >>- } aead_req; > >>- memset(&aead_req, 0, sizeof(aead_req)); > >>+ char aead_req_data[sizeof(struct aead_request) + > >>+ crypto_aead_reqsize(tfm) + > >>+ CRYPTO_MINALIGN] CRYPTO_MINALIGN_ATTR; > >Can this be a too large amount of stack? > > > >Is crypto_aead_reqsize() limited to < ~1k? > > > >Perhaps it'd be better to use kzalloc for this > >or another reserved pool > No more stack being used than with the the original code. The stack > memory use is identical. Could you explain that? It looks like aead_req_data can be bigger than original struct aead_req up to CRYPTO_MINALIGN bytes. IOW adding CRYPTO_MINALIGN to size seems unneeded as aead_request->__ctx alignment requirement should by assured by proper sizeof(struct aead_request). Besides, why not add VLAIS feature to llvm instead of fixing all programs that use it? Stanislaw -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists