linux-kernel - [PATCH 4/4] raid6: Add severity levels to raid6 initialization messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat,  8 Mar 2014 10:58:15 -0800
From:	Andy Lutomirski <luto@...capital.net>
To:	linux-kernel@...r.kernel.org
Cc:	trivial@...nel.org, Andy Lutomirski <luto@...capital.net>,
	Chris Metcalf <cmetcalf@...era.com>,
	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	Ken Steele <ken@...era.com>, Nicolas Pitre <nico@...aro.org>
Subject: [PATCH 4/4] raid6: Add severity levels to raid6 initialization messages

Some of them are errors; some are not.  Annotate them accordingly.

Signed-off-by: Andy Lutomirski <luto@...capital.net>
---
 lib/raid6/algos.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/lib/raid6/algos.c b/lib/raid6/algos.c
index f0b1aa3..6edc821 100644
--- a/lib/raid6/algos.c
+++ b/lib/raid6/algos.c
@@ -121,9 +121,10 @@ static inline const struct raid6_recov_calls *raid6_choose_recov(void)
 		raid6_2data_recov = best->data2;
 		raid6_datap_recov = best->datap;
 
-		printk("raid6: using %s recovery algorithm\n", best->name);
+		printk(KERN_DEBUG "raid6: using %s recovery algorithm\n",
+		       best->name);
 	} else
-		printk("raid6: Yikes! No recovery algorithm found!\n");
+		printk(KERN_ERR "raid6: Yikes! No recovery algorithm found!\n");
 
 	return best;
 }
@@ -157,18 +158,18 @@ static inline const struct raid6_calls *raid6_choose_gen(
 				bestperf = perf;
 				best = *algo;
 			}
-			printk("raid6: %-8s %5ld MB/s\n", (*algo)->name,
+			printk(KERN_DEBUG "raid6: %-8s %5ld MB/s\n", (*algo)->name,
 			       (perf*HZ) >> (20-16+RAID6_TIME_JIFFIES_LG2));
 		}
 	}
 
 	if (best) {
-		printk("raid6: using algorithm %s (%ld MB/s)\n",
+		printk(KERN_DEBUG "raid6: using algorithm %s (%ld MB/s)\n",
 		       best->name,
 		       (bestperf*HZ) >> (20-16+RAID6_TIME_JIFFIES_LG2));
 		raid6_call = *best;
 	} else
-		printk("raid6: Yikes!  No algorithm found!\n");
+		printk(KERN_ERR "raid6: Yikes!  No algorithm found!\n");
 
 	return best;
 }
@@ -194,7 +195,7 @@ int __init raid6_select_algo(void)
 	syndromes = (void *) __get_free_pages(GFP_KERNEL, 1);
 
 	if (!syndromes) {
-		printk("raid6: Yikes!  No memory available.\n");
+		printk(KERN_ERR "raid6: Yikes!  No memory available.\n");
 		return -ENOMEM;
 	}
 
-- 
1.8.5.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/