linux-kernel - Re: [PATCH] [RESEND] score: remove unused CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1394312534.2040.18.camel@x220>
Date:	Sat, 08 Mar 2014 22:02:14 +0100
From:	Paul Bolle <pebolle@...cali.nl>
To:	Lennox Wu <lennox.wu@...il.com>
Cc:	Michael Opdenacker <michael.opdenacker@...e-electrons.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [RESEND] score: remove unused CPU_SCORE7 Kconfig
 parameter

On Sun, 2014-03-09 at 04:27 +0800, Lennox Wu wrote:
> 2014-03-09 4:00 GMT+08:00 Paul Bolle <pebolle@...cali.nl>:
> > In https://lkml.org/lkml/2011/11/12/76 I already reported that this
> > Kconfig symbol was unused. Why can't it be dropped and re-added when
> > code is added to the tree that actually uses it?
>
> Because I don't think droping it is meaningful, since it will be used.

But, again, it isn't used now and hasn't actually been used in years.

> Moreover, the symbol never affect other architectures or subsystems.
> I feel that is not good to brother people to process the unimportant patch.

Sure, this is just a small cleanup. But the scripts people use to see
whether more serious Kconfig related issues have entered the tree will
likely notice CPU_SCORE7. (And those people will have to investigate why
that symbol is unused - which might take quite a bit of work - to
determine what needs to be done about it.) So whenever someone, not
following this thread, runs a script like that the score maintainers
might receive a similar patch again.

And I don't believe that handling a single cleanup patch is particularly
burdensome for the score maintainers.

Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/