linux-kernel - Re: [PATCH v2] mac80211: LLVMLinux: Remove VLAIS usage from mac80211

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fcb4c551-996e-42e4-a9ff-ac3c8f3bc5ea@email.android.com>
Date:	Sun, 09 Mar 2014 00:41:41 +0100
From:	Jan-Simon Möller <dl9pf@....de>
To:	Sergei Antonov <saproj@...il.com>, pageexec@...email.hu
CC:	behanw@...verseincode.com, John Linville <linville@...driver.com>,
	Johannes Berg <johannes@...solutions.net>, davem@...emloft.net,
	linux-wireless <linux-wireless@...r.kernel.org>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	David Woodhouse <dwmw2@...radead.org>,
	Vinícius Tinti <viniciustinti@...il.com>,
	Mark Charlebois <charlebm@...il.com>
Subject: Re: [PATCH v2] mac80211: LLVMLinux: Remove VLAIS usage from mac80211



On 9. März 2014 00:00:19 MEZ, Sergei Antonov <saproj@...il.com> wrote:
>On 8 March 2014 23:01, PaX Team <pageexec@...email.hu> wrote:
>> On 8 Mar 2014 at 21:29, Sergei Antonov wrote:
>>
>>> > -       memset(&aead_req, 0, sizeof(aead_req));
>>> > +       char aead_req_data[sizeof(struct aead_request) +
>>> > +                               crypto_aead_reqsize(tfm) +
>>> > +                               CRYPTO_MINALIGN]
>CRYPTO_MINALIGN_ATTR;
>>                                                     
>^^^^^^^^^^^^^^^^^^^^
>> wouldn't the underlined attribute ensure the required alignment?
>Yes. Sorry, I overlooked it.
>
>I would remove unneeded CRYPTO_MINALIGN and get the alignment from the
>target structure:
>        char aead_req_data[sizeof(struct aead_request) +
>                           crypto_aead_reqsize(tfm)]
>        __attribute__((__aligned__(__alignof__(struct aead_request))));



LGTM



-- 
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/