linux-kernel - Re: [PATCH v2 5/5] Staging: comedi: addi-data: tidy up counter register map defines in hwdrv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1394239013.11834.YahooMailNeo@web164001.mail.gq1.yahoo.com>
Date:	Fri, 7 Mar 2014 16:36:53 -0800 (PST)
From:	Chase Southwood <chase.southwood@...oo.com>
To:	Hartley Sweeten <HartleyS@...ionengravers.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Cc:	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"abbotti@....co.uk" <abbotti@....co.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 5/5] Staging: comedi: addi-data: tidy up counter register map defines in hwdrv_apci1564.c

>On Friday, March 7, 2014 11:38 AM, Hartley Sweeten <HartleyS@...ionengravers.com> wrote:

>>On Friday, March 07, 2014 1:38 AM, Chase Southwood wrote:
>>This patch fixes the register map defines for the counter registers such
>>that they are all the real offsets to each register, rather than a mix of
>>real offsets and adders to those offsets.
>>
>>Signed-off-by: Chase Southwood <chase.southwood@...oo.com>
>>---
>>
>>2: Simplified commit message, fixed indentation and whitespace damage.
>>I have test applied this patch, it should work now.
>>v2 also fixes several build breakages, and I have compile tested as well.
>>Everything should be fixed.
>
>Chase,
>
>Looks better, the patches apply now.
>
>The register map whitespace is still a bit of a mess. This is what it looks like
>after applying all 5 patches:
>

[snip]

>
>Check your tab settings in your editor. Normal tab spacing is 8 characters.
>It looks like all the defines align properly at column 49 which is one tab after
>the define on this line:
>
>#define APCI1564_TCW_WARN_TIMEBASE_REG(x)    (0x1c + ((x) * 0x20))
>
>Other than that the patches look good.

OK, yeah, for whatever reason my editor was set to 4 space tabs...I suppose
that explains why it looked perfectly aligned to me but horrifying to everyone else.
I have fixed this setting so it shouldn't be a problem going forward.
Everything appears to be properly aligned for real now, in the v3 I am
sending out momentarily.

Thanks,
Chase

>Regards,
>Hartley 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/