linux-kernel - Re: [PATCH 00/18] Resend of usbip-utils migration patches and various other fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140309165841.GA30196@kroah.com>
Date:	Sun, 9 Mar 2014 09:58:41 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Valentina Manea <valentina.manea.m@...il.com>
Cc:	devel@...verdev.osuosl.org, shuah.kh@...sung.com,
	linux-usb@...r.kernel.org, ly80toro@....cs.fau.de,
	tobias.polzer@....de, linux-kernel@...r.kernel.org,
	"Linux Kernel Community @ ROSEdu" <firefly@...ts.rosedu.org>,
	dominik.paulus@....de, Andy Grover <andy.grover@...il.com>,
	ihadzic@...earch.bell-labs.com
Subject: Re: [PATCH 00/18] Resend of usbip-utils migration patches and
 various other fixes

On Sun, Mar 09, 2014 at 05:53:51PM +0200, Valentina Manea wrote:
> I was notified that one of the patches in the series (staging: usbip:
> claim ports used by shared devices) breaks the build.
> I take full responsability for this as I haven't compiled the kernel
> with allyesconfig and I am sorry.

No worries, it happens to all of us :)

> This can be fixed by moving struct dev_state, usb_hub_claim_port() and
> usb_hub_release_port() declarations from include/linux/usb.h to
> usbip/stub.h, and leaving the declarations in usb/core/usb.h
> untouched.
> 
> Should the fix come as a separate patch or v2 of the broken one?

No, I can't redo the patch that I've already committed.

As "dev_state" is a very generic term, how about we just rename it to
something more USB specific, like usb_dev_state?  That way it would fix
the build issue, and keep it from being a problem in the future in other
drivers.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/