linux-kernel - Re: [PATCH 2/2] mm: Changed pr_warning() to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 09 Mar 2014 15:15:55 -0700
From:	Joe Perches <joe@...ches.com>
To:	Choi Gi-yong <yong@...y.org>
Cc:	tj@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mm: Changed pr_warning() to pr_warn()

On Sun, 2014-03-09 at 17:15 +0900, Choi Gi-yong wrote:
> Signed-off-by: Choi Gi-yong <yong@...y.org>

[]

> diff --git a/mm/percpu.c b/mm/percpu.c

> @@ -812,8 +812,8 @@ fail_unlock:
>  fail_unlock_mutex:
>  	mutex_unlock(&pcpu_alloc_mutex);
>  	if (warn_limit) {
> -		pr_warn("PERCPU: allocation failed, size=%zu align=%zu, "
> -			   "%s\n", size, align, err);
> +		pr_warn("PERCPU: allocation failed, size=%zu align=%zu, %s\n",
> +	size, align, err);

The second line should use 3 tabs for indentation.

		pr_warn("PERCPU: allocation failed, size=%zu align=%zu, %s\n",
			size, align, err);

If you want to become familiar with kernel style
and patching something, please practice on some
files in drivers/staging.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/