lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140309032946.GA19029@redhat.com> Date: Sat, 8 Mar 2014 22:29:46 -0500 From: Mike Snitzer <snitzer@...hat.com> To: Jens Axboe <axboe@...nel.dk> Cc: Hannes Reinecke <hare@...e.de>, Mike Snitzer <snitzer@...il.com>, Christoph Hellwig <hch@...radead.org>, Jeff Moyer <jmoyer@...hat.com>, Shaohua Li <shli@...ionio.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: block: fix q->flush_rq NULL pointer crash on dm-mpath flush On Sat, Mar 08 2014 at 10:18pm -0500, Jens Axboe <axboe@...nel.dk> wrote: > On 2014-03-08 17:57, Mike Snitzer wrote: > > > >I had a look at what you queued, thing is commit 1874198 replaced code > >in blk_kick_flush() that did use list_add_tail(). So getting back to > >the way the original code was (before 1874198) would need something > >like the following patch. > > > >But it isn't clear to me why we'd have the duality of front vs tail > >additions for flushes. Maybe Christoph knows? > > Not sure it'd even make a difference with the use case, but always > tail would be broken. But the flushing in general is a bit of a > nightmare, so I'd be inclined to add your full fix too, at least > this late in -rc. OK, please feel free to add my Signed-off-by. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists