linux-kernel - Re: [PATCH] i2c: designware-pci: Cleanup driver power management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140309083013.GA2579@katana>
Date:	Sun, 9 Mar 2014 09:30:13 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:	linux-i2c@...r.kernel.org,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	xinhuix.pan@...el.com, Jingoo Han <jg1.han@...sung.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: designware-pci: Cleanup driver power management

On Tue, Feb 04, 2014 at 02:37:07PM +0200, Mika Westerberg wrote:
> The PCI part of the DesignWare I2C driver does a lot of things that are not
> required anymore. For example drivers aren't supposed to handle PCI state
> transitions themselves. This is all provided by the PCI bus core already.
> 
> In addition to that there is no point scheduling RPM suspend on driver's
> idle hook but instead we can use RPM autosuspend for this (which is enabled
> in the driver already).
> 
> As a bonus, this patch also fixes following compile warning which is
> emitted when the driver was compiled without CONFIG_PM_RUNTIME set:
> 
> drivers/i2c/busses/i2c-designware-pcidrv.c:245:12: warning: ‘i2c_dw_pci_runtime_idle’ defined but not used [-Wunused-function]
> 
> Reported-by: xinhui.pan <xinhuix.pan@...el.com>
> Reported-by: Jingoo Han <jg1.han@...sung.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>

Applied to for-next, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)