lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 10 Mar 2014 15:26:37 +0530
From:	Sachin Kamat <>
To:	Lee Jones <>
Cc:	Krzysztof Kozlowski <>,
	LKML <>
Subject: Re: [PATCH v3 Resend 2/3] regulator: Add support for S2MPA01 regulator

Hi Lee,

On 10 March 2014 15:05, Lee Jones <> wrote:
>> >> Add support for S2MPA01 voltage and current regulator.
>> >> +
>> >> +struct s2mpa01_info {
>> >> +     struct regulator_dev *rdev[S2MPA01_REGULATOR_MAX];
>> >
>> > Hi,
>> >
>> > It seems that s2mpa01_info->rdev is not used anywhere, except as return
>> > value of devm_regulator_register. I think you can remove it completely.
>> Yes. I will send a follow up patch for this.
> Let's not break things and fix them up later. Fix it in this patch.

Nothing is broken in this patch. What is suggested is just a code cleanup.
I did not want to disturb the existing patch set as it is already reviewed
and ready for merging. Anyway I can re-spin with this suggested change.

>> > Beside that, can this driver be merged into existing s2mps11 regulator
>> > driver?
>> Haven't analyzed this yet. Will look into the possibility of consolidation
>> later.
> As above. If consolidation is possible it should be take care of in
> the first instance.

I need to analyze and see if this is really possible and the extent of
If possible, this might take a while for me before I start
implementing it. Considering
that this patch set is now over 2 months old and consolidations do
happen subsequently
I request you to queue this patch set in its current form (with the
above change if you
deem it necessary to be part of current patch set).

With warm regards,
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists