linux-kernel - Re: [PATCH] i2c-davinci: Handle signals gracefully

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140310105952.GA7227@katana>
Date:	Mon, 10 Mar 2014 11:59:52 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Mike Looijmans <mike.looijmans@...ic.nl>
Cc:	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	nsekhar@...com, khilman@...prootsystems.com,
	davinci-linux-open-source@...ux.davincidsp.com
Subject: Re: [PATCH] i2c-davinci: Handle signals gracefully


> >Even more, you should complete the whole transfer. There are devices
> >where things can really go wrong if you send a half-complete command and
> >then start with the next one. So, not checking signals at all is the way
> >to go for I2C drivers. There is some cruft left, so I am happy about
> >patches fixing that, with testing on real HW. Like yours here.
> 
> I agree.
> 
> I know the Zynq (using a cadence controller) also lets signals
> interrupt I2C transfers, so I'll propose a patch to Xilinx and CC to
> you and linux-i2c to completely remove signal handling from that
> driver as well.

Cool, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)