lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 09 Mar 2014 18:47:02 -0700 From: Joe Perches <joe@...ches.com> To: Kuninori Morimoto <kuninori.morimoto.gx@...il.com> Cc: Vinod Koul <vinod.koul@...el.com>, Morimoto <kuninori.morimoto.gx@...esas.com>, Linux-SH <linux-sh@...r.kernel.org>, linux-kernel@...r.kernel.org, Geert Uytterhoeven <geert@...ux-m68k.org>, dmaengine@...r.kernel.org Subject: Re: [PATCH v2][RESENT] dma: add R-Car Audio DMAC peri peri driver On Sun, 2014-03-09 at 18:34 -0700, Kuninori Morimoto wrote: > Add support Audio DMAC peri peri driver > for Renesas R-Car Gen2 SoC, using 'shdma-base' > DMA driver framework. Trivial notes: > diff --git a/drivers/dma/sh/rcar-audmapp.c b/drivers/dma/sh/rcar-audmapp.c [] > +static int audmapp_chan_probe(struct platform_device *pdev, > + struct audmapp_device *audev, int id) > +{ [] > + auchan = devm_kzalloc(dev, sizeof(struct audmapp_chan), GFP_KERNEL); > + if (!auchan) { > + dev_err(dev, "No free memory for allocating dma channels!\n"); Unnecessary OOM as the alloc has a generic OOM and a dump_stack() [] > +static int audmapp_probe(struct platform_device *pdev) > +{ [] > + audev = devm_kzalloc(&pdev->dev, sizeof(struct audmapp_device), > + GFP_KERNEL); > + if (!audev) { > + dev_err(&pdev->dev, "Not enough memory\n"); here too -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists