linux-kernel - Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 10 Mar 2014 13:44:41 -0500
From:	Felipe Balbi <balbi@...com>
To:	sundeep subbaraya <sundeep.lkml@...il.com>
CC:	<balbi@...com>,
	Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@...inx.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Michal Simek <michals@...inx.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

Hi,

On Mon, Mar 10, 2014 at 07:06:19PM +0530, sundeep subbaraya wrote:
> On Fri, Feb 21, 2014 at 9:09 PM, Felipe Balbi <balbi@...com> wrote:
> > Hi,
> >
> > On Fri, Feb 21, 2014 at 11:27:07AM +0000, Subbaraya Sundeep Bhatta wrote:
> >> > From the looks of it, I doubt this was actually tested, you need a lot
> >> > of work on this driver.
> >> Tested on both ARM and Microblaze architectures with Mass storage gadget.
> >> Will send a v2 after addressing all your comments.
> >
> > clearly you didn't try to remove and reinsert the module or you would
> > see a whole bunch of errors.
> >
> 
> Yes you are correct. My console hung up as soon as i rmmod my driver.
> Could you please point me where am wrong.

Many of your mistakes have already been pointed out here:

http://marc.info/?l=linux-usb&m=139292068028649&w=2

Please fix those and see if following script works:

#!/bin/sh

MODULE="xilinx_udc"

for i in $(seq 500); do
	modprobe $MODULE > /dev/null 2>&1;
	modprobe -r $MODULE > /dev/null 2>&1;
	if [ $? -eq 0 ]; then
		echo -n "."
	else
		echo -n "F"
	fi
done

echo "Finished"

you shouldn't see any F characters and your machine shouldn't crash or
hang or reboot...

Also make sure to run g_zero testcases and mass storage tescases. I
wrote, long ago, a small tool to help testing UDC drivers running with
the mass storage gadget, which you can find in [1]. There's a runner
script which makes it easy to full test suite which you can find in [2].

[1] https://gitorious.org/usb/usb-tools/source/7eb7ef21de6cd124e0e0d0e7df9ddfff0e2f548e:msc.c
[2] https://gitorious.org/usb/usb-tools/source/7eb7ef21de6cd124e0e0d0e7df9ddfff0e2f548e:msc.sh

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)