linux-kernel - Re: [PATCH V3 0/6] Drivers: net: hyperv: Enable various offloads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140310.155557.1576514754598895473.davem@davemloft.net>
Date:	Mon, 10 Mar 2014 15:55:57 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	kys@...rosoft.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	devel@...uxdriverproject.org, olaf@...fle.de, apw@...onical.com,
	jasowang@...hat.com
Subject: Re: [PATCH V3 0/6] Drivers: net: hyperv: Enable various offloads 

From: "K. Y. Srinivasan" <kys@...rosoft.com>
Date: Sat,  8 Mar 2014 19:22:42 -0800

> This patch set enables both checksum as well as segmentation offload.
> As part of this effort I have enabled scatter gather I/O a well.
> 
> In version 2 of these patches, I addressed comments from David Miller and
> Dan Carpenter.
> 
> In this version I have addressed the latest comments from David Miller.

Series applied, thanks.

I still think that fill_pg_buf() could be improved.

For example, it returns '1' if len is passed in as zero.  Maybe that can't
happen, but if it does the page buffer array will be corrupted and the
driver will process garbage.

It seems so much more straightforward to me if you simply incremented
'j' in the loop when an array entry is actually filled in.  Then just
return 'j'.

	int j;
 ...
		pb[j].pfn = page_to_pfn(page);
		pb[j].offset = offset;
		pb[j].len = bytes;
		j++;
 ...
	return j;


Then 'j' is unambiguously the number of pb array entries which were
filled in, no matter what.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/