linux-kernel - Re: [PATCH v2 0/2] kallsyms: handle special absolute symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5j+9Qt2p+dqdqcecMQ4RRb8tBVMqMDBdRGFjiRQHmDaatQ@mail.gmail.com>
Date:	Mon, 10 Mar 2014 12:58:06 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Rusty Russell <rusty@...tcorp.com.au>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Honig <ahonig@...gle.com>,
	Michal Marek <mmarek@...e.cz>,
	"x86@...nel.org" <x86@...nel.org>, Tejun Heo <tj@...nel.org>,
	Tony Luck <tony.luck@...el.com>,
	Fenghua Yu <fenghua.yu@...el.com>, linux-ia64@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 0/2] kallsyms: handle special absolute symbols

On Mon, Mar 10, 2014 at 12:06 PM, Andrew Morton
<akpm@...ux-foundation.org> wrote:
> On Fri,  7 Mar 2014 17:00:23 -0800 Kees Cook <keescook@...omium.org> wrote:
>> Handles 0-based per_cpu variables as being absolute so they are
>> not relocated under kASLR on x86_64.
>
> Would it be prudent to revert 0f55159d091cb1e5 ("kallsyms: fix absolute
> addresses for kASLR") then sort all this out for 3.15?

My opinion is that if it breaks a real-life case (avr32), it should be
reverted. The only people affected by the kallsyms per_cpu relocation
reporting bug are those using kASLR on x86, and even then the bug is a
corner case on live kernel debugging.

I am fine either way.

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/