linux-kernel - Re: [PATCH] cpufreq: Reformat printk() statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKohpok+W6hQ-2ST3+yBq4dr6qcZy61Z6dS05u1Ex-MsJ8nLFw@mail.gmail.com>
Date:	Mon, 10 Mar 2014 12:15:16 +0800
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Soren Brinkmann <soren.brinkmann@...inx.com>,
	"cpufreq@...r.kernel.org" <cpufreq@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
Subject: Re: [PATCH] cpufreq: Reformat printk() statement

On 10 March 2014 12:07, Joe Perches <joe@...ches.com> wrote:
> On Mon, 2014-03-10 at 11:53 +0800, Viresh Kumar wrote:
>> On 7 March 2014 01:34, Soren Brinkmann <soren.brinkmann@...inx.com> wrote:
>> > Reformat a printk statement to:
>> >  - use pr_warn
>> >  - bring the whole string into a single line in favor of being able to
>> >    grep for the message (ignoring the 80 char limit)
>> >
>> > Signed-off-by: Soren Brinkmann <soren.brinkmann@...inx.com>
> []
>> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
>
> A more comprehensive patch would be to:
>
> Add missing newlines
> Coalesce format fragments
> Convert printks to pr_<level>
> Align arguments
> ---
>  drivers/cpufreq/cpufreq.c | 85 ++++++++++++++++++++++-------------------------
>  1 file changed, 40 insertions(+), 45 deletions(-)

Thanks..

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/