linux-kernel - Re: [PATCH] i2c-cadence: Do not let signals interrupt I2C transfers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e690272-651a-4170-8559-cc8dc8014251@AM1EHSMHS013.ehs.local>
Date:	Mon, 10 Mar 2014 14:59:52 -0700
From:	Sören Brinkmann <soren.brinkmann@...inx.com>
To:	Mike Looijmans <mike.looijmans@...ic.nl>,
	Michal Simek <michal.simek@...inx.com>
CC:	<git@...inx.com>, <wsa@...-dreams.de>, <linux-i2c@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i2c-cadence: Do not let signals interrupt I2C transfers

Hi Mike,

The cadence driver is not in mainline yet. I think for our vendor tree
we can pretty much take it this way.
Regarding getting this into mainline, I'll send another iteration of the
change set and include these changes.

On Mon, 2014-03-10 at 12:12PM +0100, Mike Looijmans wrote:
> Pressing CTRL-C while communicating with an I2C device leads to erratic
> behaviour. The cause is that the controller will interrupt the I2C transfer
> in progress, and leave the client device in an undefined state. Many
> drivers do not handle error return codes on I2C transfers. The calling driver
> has no way of telling how much of the transfer has actually completed, so
> it cannot reliably determine the device's state.
> 
> The best solution here is to not handle signals in the I2C bus driver at all,
> but always complete a transaction before returning control.
> 
> See for a related patch and discussion on this topic:
> http://lkml.org/lkml/2014/1/9/246

Can we get your Signed-off-by, please?

> ---
>  drivers/i2c/busses/i2c-cadence.c |   12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c
> index 86713d6..32ce2ee 100644
> --- a/drivers/i2c/busses/i2c-cadence.c
> +++ b/drivers/i2c/busses/i2c-cadence.c
> @@ -452,16 +452,12 @@ static int cdns_i2c_process_msg(struct cdns_i2c *id, struct i2c_msg *msg,
>  			cdns_i2c_msend(id);
>  
>  		/* Wait for the signal of completion */
> -		ret = wait_for_completion_interruptible_timeout(
> -							&id->xfer_done, HZ);
> -		if (ret < 1) {
> +		ret = wait_for_completion_timeout(&id->xfer_done, HZ);
> +		if (ret == 0) {

To match the style used throughout the file this should just be
	if (!ret) {


Acked-by: Soren Brinkmann <soren.brinkmann@...inx.com>

	Thanks,
	Sören


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/