linux-kernel - Re: [PATCH v2 2/6] rtc: pm8xxx: use regmap API for register accesses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140310233236.GD28112@sirena.org.uk>
Date:	Mon, 10 Mar 2014 23:32:36 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Josh Cartwright <joshc@...eaurora.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	linux-arm-msm@...r.kernel.org, rtc-linux@...glegroups.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/6] rtc: pm8xxx: use regmap API for register accesses

On Mon, Mar 10, 2014 at 04:35:24PM -0500, Josh Cartwright wrote:
> On Mon, Mar 10, 2014 at 01:47:41PM -0700, Andrew Morton wrote:

> > Do we need a 

> > 	depends on REGMAP

> > in Kconfig?

> Good question.  This driver already gets the REGMAP dependency through
> it's parent (MFD_PM8XXX), which does 'select REGMAP'.

> I recall there being some history as to why individual drivers shouldn't
> explicitly depend on REGMAP, as it's the parent drivers/subsystem
> responsibility to select it when needed, however I can't recall details.
> Perhaps it's due to REGMAP not being a user-selectable option.

Yeah, it should be a select of regmap because it's more of a helper
library than a user visible feature and it's usually only on the MFD
because you can't enable the function device without the core anyway.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)