lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 10 Mar 2014 07:57:38 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	"Li.Xiubo@...escale.com" <Li.Xiubo@...escale.com>
CC:	Mark Brown <broonie@...nel.org>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [alsa-devel] [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.

On 03/10/2014 04:51 AM, Li.Xiubo@...escale.com wrote:
>> Subject: Re: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.
>>
>> On Mon, Mar 03, 2014 at 07:24:36AM +0000, Li.Xiubo@...escale.com wrote:
>>
>>>>>   	/* Default to using ALC auto offset calibration mode. */
>>>>>   	snd_soc_update_bits(codec, DA7213_ALC_CTRL1,
>>>>>   			    DA7213_ALC_CALIB_MODE_MAN, 0);
>>
>>>> This one will fail.
>>
>>> Sorry, I'm not very understand why will this fail ? Before the ASoC probe,
>>> the ASoC core will set the I/O.
>>> :)
>>
>> OK, that's now been refactored.
>
> @Mark, @Lars,
>
> Has there any other problems about this patch series? And this I had tested on
> our Vybrid-Twr board based on SGTL5000 codec and SAI drivers. If not, I can
> continue with my second patches series about " Remove set_cache_io entirely from
> ASoC probe".
>
> Thanks very much.
>


It looks good to me.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists