linux-kernel - [PATCH for-tip V2] perf/x86/uncore: Add __init for uncore_cpumask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Mar 2014 13:14:55 +0800
From:	Dongsheng Yang <yangds.fnst@...fujitsu.com>
To:	linux-kernel@...r.kernel.org
Cc:	x86@...nel.org, a.p.zijlstra@...llo.nl, paulus@...ba.org,
	mingo@...hat.com, acme@...stprotocols.net, tglx@...utronix.de,
	hpa@...or.com, Dongsheng Yang <yangds.fnst@...fujitsu.com>
Subject: [PATCH for-tip V2] perf/x86/uncore: Add __init for uncore_cpumask_init().

Commit 411cf180f introduce function uncore_cpumask_init() and it calls uncore_cpu_setup()
which is marked as __init. But it is not marked with __init, then the following warning
is there when building.

WARNING: vmlinux.o(.text+0x2464a): Section mismatch in reference from the function uncore_cpumask_init() to the function .init.text:uncore_cpu_setup()
The function uncore_cpumask_init() references
the function __init uncore_cpu_setup().
This is often because uncore_cpumask_init lacks a __init
annotation or the annotation of uncore_cpu_setup is wrong.

As function uncore_cpumask_init() is only called by __init intel_uncore_init(), then we can
free it after system initialization.

This patch add __init for uncore_cpumask_init() function.

Signed-off-by: Dongsheng Yang <yangds.fnst@...fujitsu.com>
Acked-by: Stephane Eranian <eranian@...gle.com>
---
Changlogs:
	-v1:
	   Add more commit message for this patch.

 arch/x86/kernel/cpu/perf_event_intel_uncore.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.c b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
index b262c61..5c2537a 100644
--- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
@@ -4229,7 +4229,7 @@ static int __init uncore_pmus_register(void)
 	return 0;
 }

-static void uncore_cpumask_init(void)
+static void __init uncore_cpumask_init(void)
 {
 	int cpu;

-- 
1.8.2.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/