linux-kernel - [PATCH 1/2] pstore: fix NULL pointer fault if get NULL prz in ramoops_get_next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140311061519.GA11552@lskakaxi-intel>
Date:	Tue, 11 Mar 2014 14:15:19 +0800
From:	Liu ShuoX <shuox.liu@...el.com>
To:	linux-kernel@...r.kernel.org
Cc:	anton@...msg.org, ccross@...roid.com, keescook@...omium.org,
	tony.luck@...el.com, yanmin_zhang@...ux.intel.com
Subject: [PATCH 1/2] pstore: fix NULL pointer fault if get NULL prz in
 ramoops_get_next_prz

These two patches are applied on top of patches:
https://lkml.org/lkml/2014/3/3/368
It has been added in -mm tree. Below is the first patch, and i will
send the second by replying this one.

From: Liu ShuoX <shuox.liu@...el.com>

ramoops_get_next_prz get the prz according the paramters. If it get a
uninitialized prz, access its members by following persistent_ram_old_size(prz)
will cause a NULL pointer crash.
Ex: if ftrace_size is 0, fprz will be NULL.

Fix it by return NULL in advance.

Signed-off-by: Liu ShuoX <shuox.liu@...el.com>
---
  fs/pstore/ram.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index 1daed28..6f96d8c 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -119,6 +119,8 @@ ramoops_get_next_prz(struct persistent_ram_zone *przs[], uint *c, uint max,
  		return NULL;
  
  	prz = przs[i];
+	if (!prz)
+		return NULL;
  
  	/* Update old/shadowed buffer. */
  	if (update)
-- 
1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/