linux-kernel - Re: [PATCH 1/1] HFSPLUS: add __init to hfsplus_create_attr_tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 11 Mar 2014 10:38:08 +0400
From:	Vyacheslav Dubeyko <slava@...eyko.com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	akpm <akpm@...ux-foundation.org>, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 1/1] HFSPLUS: add __init to
 hfsplus_create_attr_tree_cache()

On Mon, 2014-03-10 at 21:56 +0100, Fabian Frederick wrote:
> hfsplus_create_attr_tree_cache is only called by __init init_hfsplus_fs
> 

I think that it is the reasonable fix. Looks good for me.

Reviewed-by: Vyacheslav Dubeyko <slava@...eyko.com>

Thanks,
Vyacheslav Dubeyko.

> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  fs/hfsplus/attributes.c | 2 +-
>  fs/hfsplus/hfsplus_fs.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/hfsplus/attributes.c b/fs/hfsplus/attributes.c
> index 0f47890..caf89a7 100644
> --- a/fs/hfsplus/attributes.c
> +++ b/fs/hfsplus/attributes.c
> @@ -11,7 +11,7 @@
>  
>  static struct kmem_cache *hfsplus_attr_tree_cachep;
>  
> -int hfsplus_create_attr_tree_cache(void)
> +int __init hfsplus_create_attr_tree_cache(void)
>  {
>  	if (hfsplus_attr_tree_cachep)
>  		return -EEXIST;
> diff --git a/fs/hfsplus/hfsplus_fs.h b/fs/hfsplus/hfsplus_fs.h
> index 08846425b..bb75586 100644
> --- a/fs/hfsplus/hfsplus_fs.h
> +++ b/fs/hfsplus/hfsplus_fs.h
> @@ -366,7 +366,7 @@ typedef int (*search_strategy_t)(struct hfs_bnode *,
>   */
>  
>  /* attributes.c */
> -int hfsplus_create_attr_tree_cache(void);
> +int __init hfsplus_create_attr_tree_cache(void);
>  void hfsplus_destroy_attr_tree_cache(void);
>  hfsplus_attr_entry *hfsplus_alloc_attr_entry(void);
>  void hfsplus_destroy_attr_entry(hfsplus_attr_entry *entry_p);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/