linux-kernel - [PATCH] staging: unisys: remove incorrect error handling after queue_delayed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 11 Mar 2014 00:31:03 -0700 (PDT)
From:	Daeseok Youn <daeseok.youn@...il.com>
To:	gregkh@...uxfoundation.org
Cc:	jkc@...hat.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] staging: unisys: remove incorrect error handling after queue_delayed_work


The queue_delayed_work() return false if the work is
already on the queue, true otherwise.
So return value cannot be less than zero.

Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>
---
 .../unisys/visorchipset/visorchipset_main.c        |   14 ++++----------
 1 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c b/drivers/staging/unisys/visorchipset/visorchipset_main.c
index 400cb03..0dff759 100644
--- a/drivers/staging/unisys/visorchipset/visorchipset_main.c
+++ b/drivers/staging/unisys/visorchipset/visorchipset_main.c
@@ -2055,11 +2055,8 @@ Away:
 		}
 	}
 
-	if (queue_delayed_work(Periodic_controlvm_workqueue,
-			       &Periodic_controlvm_work, Poll_jiffies) < 0) {
-		LOGERR("queue_delayed_work failed!");
-		POSTCODE_LINUX_2(QUEUE_DELAYED_WORK_PC, POSTCODE_SEVERITY_ERR);
-	}
+	queue_delayed_work(Periodic_controlvm_workqueue,
+			   &Periodic_controlvm_work, Poll_jiffies);
 }
 
 static void
@@ -2193,11 +2190,8 @@ Away:
 
 	Poll_jiffies = POLLJIFFIES_CONTROLVMCHANNEL_SLOW;
 
-	if (queue_delayed_work(Periodic_controlvm_workqueue,
-			       &Periodic_controlvm_work, Poll_jiffies) < 0) {
-		LOGERR("queue_delayed_work failed!");
-		POSTCODE_LINUX_2(QUEUE_DELAYED_WORK_PC, POSTCODE_SEVERITY_ERR);
-	}
+	queue_delayed_work(Periodic_controlvm_workqueue,
+			   &Periodic_controlvm_work, Poll_jiffies);
 }
 
 static void
-- 
1.7.4.4


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/